fix: Support Pandas future.infer_string=True in report generation #1674
+46
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssiegel
changed the title
ssiegel
force-pushed
the
fix-pd-future-infer-string
branch
from
0364724 to
d65a768
Compare
Previously, report generation encountered issues when
`future.infer_string=True` was set. This resulted in multiple warnings
("FutureWarning: Dtype inference on a pandas object is deprecated") and
failures when string columns contained only empty strings
("AttributeError: 'StringDtype' object has no attribute
'pyarrow_dtype'").
This change resolves the issue by explicitly setting the dtype to
"object" for the relevant operations.
fabclmnt
force-pushed
the
fix-pd-future-infer-string
branch
from
40829e8 to
37cc39f
Compare
fabclmnt
approved these changes
Jan 29, 2025
|
@ssiegel thank you for your contribution. It seems like your contributions failed to pass the tests. Can you please review it? |
- Introduce the `optional_option_context` helper to replace the direct
use of `pd.option_context("future.no_silent_downcasting", True)`,
ensuring compatibility with older pandas versions that lack this
option.
- Update the `future.infer_string` test to run only on pandas >= 2.1,
where it is applicable.
|
I have no idea what the failing "Pull Request / Lint commit message (pull_request)" and "Pull Request / Lint source code (pull_request)" tests are about. The error messages don't look like they are related to anything I touched. N.B. A lot of tests were failing when I tested locally with pandas<1.3. The corresponding line in requirements.txt might be out of date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, report generation encountered issues when
future.infer_string=Truewas set. This resulted in multiple warnings ("FutureWarning: Dtype inference on a pandas object is deprecated") and failures when string columns contained only empty strings ("AttributeError: 'StringDtype' object has no attribute 'pyarrow_dtype'").This change resolves the issue by explicitly setting the dtype to "object" for the relevant operations.